Stub functions to get publisher and subcription informations like QoS policies from topic name #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaofei <miaofei@amazon.com>
mm318
force-pushed
the
miaofei/stub_qos_in_topic_info
branch
from
049f3da
to
cb86bc5
Compare
ivanpauno
requested changes
Jan 3, 2020
| @@ -266,6 +266,22 @@ NodeGraph::count_subscribers(const std::string & topic_name) const | |||
| return count; | |||
| } | |||
|
|
|||
| std::vector<rmw_topic_info_t> | |||
There was a problem hiding this comment.
rmw_topic_info_t is too "C style", specially because of the C style strings.
I think that the way to go is creating an equivalent cpp class.
It will force some extra unnecessary copying, but performance is not much important in graph instronspection functions.
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Closing this pull request in favor of #960. |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For addressing #943 (comment)
This is similar to ros2/rclpy#454, but for
rclcppand will have no implementation right now.